Skip to content

Fix:#780 Miguel/editor fix #783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
migsan1104 wants to merge 5 commits into from
Closed

Fix:#780 Miguel/editor fix #783

migsan1104 wants to merge 5 commits into from

Conversation

@migsan1104
Copy link

@migsan1104 migsan1104 commented Jun 5, 2025

This PR addresses issue #780 by implementing behavior consistent with modern editors:

If the user right-clicks inside an existing selection, the selection is preserved.

If the user right-clicks outside the selection, the caret moves to the clicked position and the context menu is invoked at the new location. The selection is also cleared.

Added build/ to .gitignore to avoid tracking generated files.

migsan1104 added 4 commits June 4, 2025 17:09
@migsan1104
Fix dail8859#780: Preserve selection on right-click inside, if right-…
ae473f3 
…click outside selection the selection is cleared and caret is moved. Context menu is then opened based on new caret location.
@migsan1104
WIP: Temporary save before rebase
abf8750
@migsan1104
Fix dail8859#780: Preserve selection on right-click inside. Move care…
8d6a0f3 
…t when right-clicked outside selection and show context menu at new caret location.
@migsan1104
Remove build artifacts from version control and ignore build/ folder
f719a91
@migsan1104
Copy link
Author

migsan1104 commented Jun 5, 2025

Thank you for letting me work on this project. :)

@migsan1104 migsan1104 closed this Jun 9, 2025
@migsan1104 migsan1104 reopened this Jun 9, 2025
@dail8859
Copy link
Owner

dail8859 commented Jun 15, 2025

Hi @migsan1104 apologies for the delay.

Although I think this is likely a valid solution, all the code within the scintilla directory is directly from a 3rd party library so I wouldn't want to maintain a separate copy or need to remember to edit it every time.

My first guess is that this section of code is the best place to handle it:

NotepadNext/src/NotepadNext/dialogs/MainWindow.cpp

Lines 1973 to 2010 in 6ab46c4

connect(editor, &ScintillaNext::customContextMenuRequested, this, [=](const QPoint &pos) {
contextMenuPos = editor->positionFromPoint(pos.x(), pos.y());
QStringList actionNames = {
"Cut",
"Copy",
"Paste",
"Delete",
"",
"SelectAll",
"",
"Base64Encode",
"URLEncode",
"",
"Base64Decode",
"URLDecode"
};
// If the entry exists in the settings, use that
ApplicationSettings *settings = app->getSettings();
if (settings->contains("Gui/EditorContextMenu")) {
actionNames = settings->value("Gui/EditorContextMenu").toStringList();
}
// If the cursor is at a URL, prepend the action
URLFinder *urlFinder = editor->findChild<URLFinder *>(QString(), Qt::FindDirectChildrenOnly);
if (urlFinder && urlFinder->isEnabled() && urlFinder->isURL(contextMenuPos)) {
actionNames.prepend("");
actionNames.prepend("CopyURL");
}
auto menu = buildMenu(actionNames);
menu->addSeparator();
menu->addMenu(ui->menuMarkAllOccurrences);
menu->addMenu(ui->menuClearMarks);
menu->popup(QCursor::pos());
});

That is where the main window shows the context menu and may need to do some checking to see if its in a selection or not and possibly clear the selection.

Notepad++ also has this behavior and also uses Scintilla so it might have a recommended way of handling this case, but I havent taken the time to dig into the Notepad++ source code in quite a while.

@dail8859 dail8859 closed this Jun 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@migsan1104 @dail8859